Skip to content

Regenerate Filebeat golden files to account for Elasticsearch 7.13#25147

Closed
adriansr wants to merge 3 commits intoelastic:masterfrom
adriansr:regenerate_7.13_golden_files
Closed

Regenerate Filebeat golden files to account for Elasticsearch 7.13#25147
adriansr wants to merge 3 commits intoelastic:masterfrom
adriansr:regenerate_7.13_golden_files

Conversation

@adriansr
Copy link
Copy Markdown
Contributor

No description provided.

@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 19, 2021
@botelastic
Copy link
Copy Markdown

botelastic Bot commented Apr 19, 2021

This pull request doesn't have a Team:<team> label.

@adriansr adriansr changed the title Regenerate Filebeat golden files due to changes in Elasticsearch 7.13 Regenerate Filebeat golden files to account for Elasticsearch 7.13 Apr 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25147 updated

  • Start Time: 2021-04-19T17:00:22.716+0000

  • Duration: 68 min 13 sec

  • Commit: 73f20bb

Test stats 🧪

Test Results
Failed 0
Passed 13531
Skipped 2271
Total 15802

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13531
Skipped 2271
Total 15802

@@ -60,7 +60,7 @@
"@timestamp": "2020-05-18T14:38:58.000-02:00",
"client.ip": "83.20.132.250",
"destination.as.number": 721,
"destination.as.organization.name": "DoD Network Information Center",
"destination.as.organization.name": "DNIC-ASBLK-00721-00726",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a big change to the expected values. It's very likely to affect users that are filtering or alerting on AS org names. Do we have any idea if this is a change caused by something in Elasticsearch code or if it's something that MaxMind changed?

@probakowski Would you happen to have any insight? (saw you on a bunch of geoip related PRs)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes for *.geo.* fields are for sure connected with GeoIPv2 project that finished recently. We haven't updated MaxMind databases for a long time (end of 2019?) due to license change and now we do update them to the latest released by MaxMind every 3 days (we still ship old databases but right after cluster start this new component kicks in and downloads new files)

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 19, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b regenerate_7.13_golden_files upstream/regenerate_7.13_golden_files
git merge upstream/master
git push upstream regenerate_7.13_golden_files

@adriansr
Copy link
Copy Markdown
Contributor Author

#25141 already addressed this issues. Closing.

@adriansr adriansr closed this Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs_team Indicates that the issue/PR needs a Team:* label review :Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants