Dockerfile for Metricbeat to test cgroups #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #-------------------------- Elasticsearch output ------------------------------ | ||
| output.elasticsearch: | ||
| # Array of hosts to connect to. | ||
| hosts: ["localhost:9200"] |
There was a problem hiding this comment.
That is probably not going to work as elasticsearch is not running on localhost but elasticsearch. The environment variables should be used ehre.
There was a problem hiding this comment.
The elasticsearch is set in the command for running metricbeat in the Dockerfile-5.0.0-cgroups.
monicasarbu
force-pushed
the
testing_containers_for_cgroups
branch
from
015ea61 to
641c8c3
Compare
| enabled: true | ||
| period: 10s | ||
| processes: ['.*'] | ||
| cgroups: true |
monicasarbu
force-pushed
the
testing_containers_for_cgroups
branch
2 times, most recently
from
0f2f64d to
2e01905
Compare
| @@ -10,6 +10,10 @@ stop: | |||
| ${BASE_COMMAND} stop | |||
| ${BASE_COMMAND} rm -f | |||
|
|
|||
|
|
|||
| up: | |||
There was a problem hiding this comment.
I recommend also to run the build command before running up, to make sure you always have the most recent environment.
There was a problem hiding this comment.
Yes, you are right. I am adding build before.
run make up ENV=5.0.0-cgroups.yml
monicasarbu
force-pushed
the
testing_containers_for_cgroups
branch
from
4e839a5 to
ddfcc1a
Compare
|
I addressed all comments, and it's ready for another review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Dockerfile for Metricbeat to test cgroups functionality.
You need to run the following commands to start a container with Kibana, one with Elasticsearch and one with Metricbeat:
To stop all the containers, you can use: