Cherry-pick #24250 to 7.x: Port four Harvester tests of log input to filestream in Golang#24882
Merged
kvch merged 1 commit intoelastic:7.xfrom Apr 1, 2021
Merged
Cherry-pick #24250 to 7.x: Port four Harvester tests of log input to filestream in Golang#24882kvch merged 1 commit intoelastic:7.xfrom
kvch merged 1 commit intoelastic:7.xfrom
Conversation
kvch
added
[zube]: In Review
backport
Team:Elastic-Agent
Contributor
|
Pinging @elastic/agent (Team:Agent) |
botelastic
Bot
added
needs_team
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 1 |
| Passed | 46398 |
| Skipped | 5174 |
| Total | 51573 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Build&Test / x-pack/elastic-agent-windows-2008-windows-2008-r2 / TestConfigurableFailed – github.com/elastic/beats/v7/x-pack/elastic-agent/pkg/agent/operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #24250 to 7.x branch. Original message:
What does this PR do?
This PR ports the following Python tests of the
loginput tofilestreamto Golang:test_harvester.py:test_close_removedtest_harvester.py:test_empty_linestest_harvester.py:test_empty_lines_onlytest_harvester.py:test_exceed_bufferWhy is it important?
Increase the test coverage of
filestream.Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.