Cherry-pick #24864 to 7.x: Use identifier in HarvesterGroup in filestream#24873
Merged
kvch merged 1 commit intoelastic:7.xfrom Mar 31, 2021
Merged
Cherry-pick #24864 to 7.x: Use identifier in HarvesterGroup in filestream#24873kvch merged 1 commit intoelastic:7.xfrom
kvch merged 1 commit intoelastic:7.xfrom
Conversation
kvch
added
[zube]: In Review
backport
Team:Elastic-Agent
Contributor
|
Pinging @elastic/agent (Team:Agent) |
botelastic
Bot
added
needs_team
(cherry picked from commit 23bfcd9)
kvch
force-pushed
the
backport_24864_7.x
branch
from
7d26885 to
076f67e
Compare
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #24864 to 7.x branch. Original message:
What does this PR do?
This PR adds
sourceIdentifiertodefaultHarvesterGroupso it uses the same method to access entries in the registry as theProspector.Why is it important?
Previously, the
HarvesterGroupandProspectorlooked for the same resources but got different IDs.HarvesterGroupwas not aware of thefilestream::{user_id}prefix, thus theProspectornever found the entries created by theHarvesterGroupand vica versa.Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.