Skip to content

Cherry-pick #24515 to 7.11: [Auditbeat] btmp offset check#24551

Merged
leehinman merged 1 commit intoelastic:7.11from
leehinman:backport_24515_7.11
Mar 16, 2021
Merged

Cherry-pick #24515 to 7.11: [Auditbeat] btmp offset check#24551
leehinman merged 1 commit intoelastic:7.11from
leehinman:backport_24515_7.11

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

@leehinman leehinman commented Mar 15, 2021

Cherry-pick of PR #24515 to 7.11 branch. Original message:

What does this PR do?

Adds check that saved offset is not larger than the current file size.

Why is it important?

This prevents seeking past the end of the file.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

Bug report contained logs like:

  2021-03-01T10:58:05.161+0100	DEBUG	[login]	login/utmp.go:204	Reading file /var/log/btmp (utmpFile={Inode:1704287 Path:/var/log/btmp Size:1536 Offset:10752 Type:1})

* auditbeat btmp offset check

Add check that saved offset is not larger than the current file size
to prevent seeking past the end of file

(cherry picked from commit b03a935)
@leehinman leehinman requested a review from a team as a code owner March 15, 2021 17:55
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 15, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 15, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24551 opened

  • Start Time: 2021-03-15T17:57:18.142+0000

  • Duration: 31 min 58 sec

  • Commit: ab5199e

Test stats 🧪

Test Results
Failed 0
Passed 337
Skipped 145
Total 482

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 337
Skipped 145
Total 482

@leehinman leehinman merged commit 3ec3ae8 into elastic:7.11 Mar 16, 2021
@leehinman leehinman deleted the backport_24515_7.11 branch March 16, 2021 14:53
@zube zube Bot removed the [zube]: Done label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants