Cherry-pick #24515 to 7.12: [Auditbeat] btmp offset check#24550
Merged
leehinman merged 2 commits intoelastic:7.12from Mar 16, 2021
Merged
Cherry-pick #24515 to 7.12: [Auditbeat] btmp offset check#24550leehinman merged 2 commits intoelastic:7.12from
leehinman merged 2 commits intoelastic:7.12from
Conversation
* auditbeat btmp offset check Add check that saved offset is not larger than the current file size to prevent seeking past the end of file (cherry picked from commit b03a935)
botelastic
Bot
added
the
needs_team
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
Bot
removed
the
needs_team
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
marc-gr
approved these changes
Mar 16, 2021
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* auditbeat btmp offset check Add check that saved offset is not larger than the current file size to prevent seeking past the end of file (cherry picked from commit 920fd38)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #24515 to 7.12 branch. Original message:
What does this PR do?
Adds check that saved offset is not larger than the current file size.
Why is it important?
This prevents seeking past the end of the file.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Logs
Bug report contained logs like: