go.mod: update go-licence-detector to v0.5.0#24117
Closed
axw wants to merge 4 commits intoelastic:masterfrom
Closed
go.mod: update go-licence-detector to v0.5.0#24117axw wants to merge 4 commits intoelastic:masterfrom
axw wants to merge 4 commits intoelastic:masterfrom
Conversation
go-licence-detector v0.5.0 added support for local module replacements, which are used when in the APM Server Beats update job.
botelastic
Bot
added
the
needs_team
Member
Author
|
/run apm-beats-update |
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 45879 |
| Skipped | 4004 |
| Total | 49883 |
botelastic
Bot
removed
the
needs_team
kvch
approved these changes
Feb 19, 2021
Contributor
|
The PR is still failing with the same error, but I think this can go in regardless. |
Member
|
Failing tests in metricbeat were caused by temporary errors connecting with docker hub/cloudflare: |
|
Hi! We're labeling this issue as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update go-licence-detector to v0.5.0.
Why is it important?
Local module replacements are used in the APM Server Beats update job, and the job is failing because "beats-local" doesn't have the right licence. go-licence-detector v0.5.0 added support for local module replacements.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.