Enhance contains condition to work on fields that are arrays of string #2248
Conversation
| @@ -269,26 +269,36 @@ func (c *Condition) checkEquals(event common.MapStr) bool { | |||
| } | |||
|
|
|||
| func (c *Condition) checkContains(event common.MapStr) bool { | |||
|
|
|||
| outer: | |||
There was a problem hiding this comment.
Why no love for the label? Naming?
There was a problem hiding this comment.
It's not supported in my brain :-D
|
LGTM |
| if !strings.Contains(*value.(*string), equalValue) { | ||
| return false | ||
| } | ||
| case []string: |
There was a problem hiding this comment.
@andrewkroh why not ?
found := false
for _, s := range value.([]string) {
if strings.Contains(s, equalValue) {
found = true
}
}
if !found {
return false
}
There was a problem hiding this comment.
They are equivalent if you add the required break statement to the snippet above. But the code in the PR is a bit more concise.
|
@andrewkroh does it work without updating setContains() function? |
|
@andrewkroh can you please add documentation for it? |
Yes, |
I have updated to docs. See #2285 |
Addresses #2237