Change cloud.provider from googlecloud to gcp in billing metricset #22287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
kaiyan-sheng
added
needs_backport
Collaborator
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
Collaborator
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
ChrsMark
approved these changes
Oct 30, 2020
kaiyan-sheng
added
v7.11.0
and removed
needs_backport
kaiyan-sheng
added a commit
that referenced
this pull request
Oct 30, 2020
kaiyan-sheng
added a commit
that referenced
this pull request
Oct 30, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 30, 2020
* upstream/master: [JJBB] Add 6.8+ branches (elastic#22321) [CI] Support Windows-8 (elastic#22307) Change cloud.provider from googlecloud to gcp in billing metricset (elastic#22287) [packaging][beats-tester] use commit id binaries (elastic#22027) [CI] Report error in the catch section (elastic#22297)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 30, 2020
* upstream/master: [JJBB] Add 6.8+ branches (elastic#22321) [CI] Support Windows-8 (elastic#22307) Change cloud.provider from googlecloud to gcp in billing metricset (elastic#22287) [packaging][beats-tester] use commit id binaries (elastic#22027) [CI] Report error in the catch section (elastic#22297)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to change
cloud.providerfromgooglecloudtogcpin billing metricset to match the rest of the metricsets undergooglecloudmodule. This is to match the definition of this field in ECS.The rest of the metricsets under
googlecloudmodule hadcloud.providerchanged togcpin #21775.