Skip to content

Update shared-autodiscover.asciidoc #21734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update shared-autodiscover.asciidoc #21734

wants to merge 1 commit into from

Conversation

@newly12
Copy link
Contributor

@newly12 newly12 commented Oct 13, 2020

add descriptions for default values of labels.dedot and annotations.dedot, it helps user to understand the default behavior without looking into the code.

@newly12
Update shared-autodiscover.asciidoc
6819206 
add descriptions for default values of `labels.dedot` and `annotations.dedot`
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 13, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 13, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 13, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 13, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [kvch commented: jenkins run tests]

  • Start Time: 2020-10-13T11:09:52.413+0000

  • Duration: 23 min 6 sec

@kvch
Copy link
Contributor

kvch commented Oct 13, 2020

jenkins run tests

@andresrc andresrc added the Team:Platforms Label for the Integrations - Platforms team label Oct 13, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 13, 2020

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 13, 2020
@mtojek
Copy link
Contributor

mtojek commented Oct 14, 2020

@newly12 could you please open this PR against the master branch?

@mtojek mtojek self-assigned this Oct 14, 2020
@newly12
Copy link
Contributor Author

newly12 commented Oct 15, 2020

ahh sorry.. I clicked the edit button on the doc website and didn't notice the target branch. I've closed this one and opened #21827

@newly12 newly12 closed this Oct 15, 2020
@newly12 newly12 deleted the patch-1 branch October 15, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mtojek mtojek

Labels

Team:Platforms Label for the Integrations - Platforms team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@newly12 @elasticmachine @kvch @mtojek @andresrc