Skip to content

chore: create CI artifacts for DEV usage #21645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2020
Merged

chore: create CI artifacts for DEV usage #21645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .ci/packaging.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,12 @@ def runE2ETestForPackages(){

def release(){
withBeatsEnv(){
dir("${env.BEATS_FOLDER}") {
sh(label: "Release ${env.BEATS_FOLDER} ${env.PLATFORMS}", script: 'mage package')
withEnv([
"DEV=true"
]) {
dir("${env.BEATS_FOLDER}") {
sh(label: "Release ${env.BEATS_FOLDER} ${env.PLATFORMS}", script: 'mage package')
}
Copy link
Contributor

@ph ph Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not completely familiar with the CI here, would that run DEV=true mage package for all the beats, quick grep through the code I don't think it would have any impact.

Copy link
Contributor Author

@mdelapenya mdelapenya Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release() method is called for linux/Mac release: https://github.com/elastic/beats/pull/21645/files#diff-bdaa5a61de14efda6eb2bbb2a38fa9a8R93-R148

Copy link
Member

@andrewkroh andrewkroh Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV doesn't affect mage package AFAIK. Does it affect something else?

You can produce "snapshot" artifacts from packaging with SNAPSHOT=true if that's what you're looking for.

Copy link
Contributor Author

@mdelapenya mdelapenya Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ph are we ok if we use SNAPSHOT instead?

Copy link
Contributor

@michalpristas michalpristas Oct 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV is used by agent so it skips verification of the artifacts, agent does verify both normal builds and snapshot artifacts. without this artifacts from PRs will fail on these verifications as they wont be signed and 8.0.0-SNAPSHOT artifact published is different
it is a new flag so it should not alter other behavior

Copy link
Contributor Author

@mdelapenya mdelapenya Oct 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other concern about @michalpristas's comment? We'd like to merge this to fix some of the errors we see at the e2e tests

}
publishPackages("${env.BEATS_FOLDER}")
}
Expand Down