-
Notifications
You must be signed in to change notification settings - Fork 5k
Cherry-pick #21380 to 7.x: [filebeat] Fix shutdown tracking in s3 input #21396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit d8d35a1)
|
Pinging @elastic/integrations (Team:Integrations) |
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Cherry-pick of PR #21380 to 7.x branch. Original message:
This is just a short fix -- the s3 input's wait group (used to wait for shutdown) currently calls
wg.Done()immediately after the (asynchronous) call site, so thewg.Wait()on shutdown is always a no-op. This PR moves thewg.Done()call to the end of the worker goroutine, which is probably what was intended.