Skip to content

Conversation

@afharo
Copy link
Member

@afharo afharo commented Sep 18, 2020

Backports the following commits to 7.9:

@afharo afharo self-assigned this Sep 18, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 18, 2020
@botelastic
Copy link

botelastic bot commented Sep 18, 2020

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 18, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21162 updated]

  • Start Time: 2020-09-18T16:46:44.286+0000

  • Duration: 72 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 3108
Skipped 687
Total 3795

@afharo
Copy link
Member Author

afharo commented Sep 18, 2020

jenkins, test this please

@afharo afharo force-pushed the backport/7.9/pr-20772 branch 2 times, most recently from add6402 to 4ce63d7 Compare September 18, 2020 14:03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @afharo I know this PR is not ready for review yet, but just wanted to point out that the main reason you're seeing extra changes in this backport PR vs. the original one is these extra lines in the CHANGELOG. It's a common issue we see with backport PRs 🙂.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! thanks for pointing that out! I'll make sure to remove the extra additions

@afharo afharo force-pushed the backport/7.9/pr-20772 branch from 4ce63d7 to 1d67291 Compare September 18, 2020 14:27
@afharo afharo force-pushed the backport/7.9/pr-20772 branch from 1d67291 to 1801fc5 Compare September 18, 2020 16:45
@afharo afharo requested a review from ycombinator September 18, 2020 17:57
@afharo
Copy link
Member Author

afharo commented Sep 18, 2020

All tests finally passed! 🎉 @ycombinator can you take a quick look at this PR, please?

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@afharo afharo merged commit 1979d78 into elastic:7.9 Sep 18, 2020
@afharo afharo deleted the backport/7.9/pr-20772 branch September 18, 2020 18:01
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…t getting usage stats (elastic#20772) (elastic#21162)

Co-authored-by: Shaunak Kashyap <[email protected]>

Co-authored-by: Shaunak Kashyap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants