Skip to content

Conversation

@kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Sep 17, 2020

Cherry-pick of PR #21101 to 7.9 branch. Original message:

What does this PR do?

This PR is to fix panic in aws metricbeat module for by skipping running output.AccountAliases[0] after checking if the length of output.AccountAliasesis zero.

"panic": "runtime error: index out of range [0] with length 0"

Why is it important?

This error will happen when the user is trying to collect metrics with an account that does not have an account alias.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas

- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [ ] I have added tests that prove my fix is effective or that my feature works

  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

* Fix index out of range error when getting AWS account name

(cherry picked from commit 568fbff)
@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Sep 17, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 17, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Sep 17, 2020
Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 17, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21144 updated]

  • Start Time: 2020-09-17T16:49:33.263+0000

  • Duration: 43 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 768
Skipped 72
Total 840

@kaiyan-sheng kaiyan-sheng merged commit 5f9fafd into elastic:7.9 Sep 17, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_21101_7.9 branch September 17, 2020 17:40
@zube zube bot removed the [zube]: Done label Dec 17, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…etting AWS account name (elastic#21144)

* Fix index out of range error when getting AWS account name (elastic#21101)
(cherry picked from commit 749e0ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Platforms Label for the Integrations - Platforms team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants