Cherry-pick #21101 to 7.x: Fix index out of range error when getting AWS account name #21143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix index out of range error when getting AWS account name (cherry picked from commit 568fbff)
kaiyan-sheng
added
[zube]: In Review
backport
Team:Platforms
botelastic
bot
added
the
needs_team
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
narph
approved these changes
Sep 17, 2020
Contributor
narph
left a comment
narph
left a comment
There was a problem hiding this comment.
LGTM , besides the branch conflicts
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21101 to 7.x branch. Original message:
What does this PR do?
This PR is to fix panic in aws metricbeat module for by skipping running
output.AccountAliases[0]after checking if the length ofoutput.AccountAliasesis zero.Why is it important?
This error will happen when the user is trying to collect metrics with an account that does not have an account alias.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues