Skip to content

Conversation

@aschifman
Copy link
Contributor

@aschifman aschifman commented Aug 26, 2020

Adding note of clarity as users will not see a proper indice name if they have not previously run the {beatname_uc} setup command.

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Adding note of clarity as users will not see a proper indice name if they have not previously run the {beatname_uc} setup command.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 26, 2020
@kilfoyle kilfoyle requested a review from dedemorton August 26, 2020 15:22
@aschifman aschifman added the Team:Docs Label for the Observability docs team label Aug 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 26, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20802 opened]

  • Start Time: 2020-08-26T15:15:59.169+0000

  • Duration: 23 min 33 sec

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dedemorton dedemorton added the needs_backport PR is waiting to be backported to other branches. label Sep 1, 2020
@dedemorton
Copy link
Contributor

@aschifman This change will need to be backported to 7.x and master. Do you want me to do that?

@aschifman
Copy link
Contributor Author

Whatever is easiest for you, thank you. I am not familiar with the process. I am just learning how to do these small edits, so if you are able to show me the process, I'll perhaps be able to take care of these little ones.

@dedemorton dedemorton merged commit aaac11c into 7.9 Sep 16, 2020
@dedemorton dedemorton deleted the aschifman-patch-1 branch September 16, 2020 02:10
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Sep 16, 2020
Adding note of clarity as users will not see a proper indice name if they have not previously run the {beatname_uc} setup command.
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Sep 16, 2020
Adding note of clarity as users will not see a proper indice name if they have not previously run the {beatname_uc} setup command.
dedemorton added a commit that referenced this pull request Sep 16, 2020
Adding note of clarity as users will not see a proper indice name if they have not previously run the {beatname_uc} setup command.

Co-authored-by: Aaron M. Schifman <[email protected]>
dedemorton added a commit that referenced this pull request Sep 16, 2020
Adding note of clarity as users will not see a proper indice name if they have not previously run the {beatname_uc} setup command.

Co-authored-by: Aaron M. Schifman <[email protected]>
v1v added a commit to v1v/beats that referenced this pull request Sep 18, 2020
…ne-2.0

* upstream/master: (44 commits)
  Update users.asciidoc (elastic#20802) (elastic#21108)
  Fix docker provider builder. (elastic#21118)
  [Elastic Agent] Add docker composable dynamic provider. (elastic#20842)
  Add new modules/filesets from rsa2elk for 7.10 (elastic#20820)
  Fix broken links to external websites (elastic#21061)
  [docs] typo in the command line (elastic#20799)
  [Filebeat] add panos type and sub_type (elastic#20912)
  Move the `compute_vm_scalset` to  a light metricset and map the cloud metadata (elastic#21038)
  [Filebeat] Add support for Cloudtrail digest files (elastic#21086)
  Add metrics collection from cost explorer into aws/billing metricset (elastic#20527)
  Add vendoring to Google Cloud Functions again (elastic#21070)
  [Elastic Agent] Add fleet.host.id for sending to endpoint. (elastic#21042)
  Do not need Google credentials before using it (elastic#21072)
  [Filebeat][New Module] Zoom webhook module (elastic#20414)
  Add support for GMT timezone offset in decode_cef (elastic#20993)
  Filebeat: Fix random error on harvester close (elastic#21048)
  Add ingress controller dashboards (elastic#21052)
  Fix loggers in composable module. (elastic#21047)
  [Ingest Manager] Increase kibana client timeout to 5 minutes (elastic#21037)
  Add changelog. (elastic#21041)
  ...
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Adding note of clarity as users will not see a proper indice name if they have not previously run the {beatname_uc} setup command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs_backport PR is waiting to be backported to other branches. Team:Docs Label for the Observability docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants