Fix starttime of metricsets on dataset endpoint for metricbeat #19975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
botelastic
bot
added
the
needs_team
vjsamuel
force-pushed
the
fix_dataset_starttime
branch
from
f5421f7 to
cdf80f1
Compare
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
vjsamuel
force-pushed
the
fix_dataset_starttime
branch
from
cdf80f1 to
978ce7e
Compare
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
jenkins run the tests please |
urso
approved these changes
Jul 21, 2020
Merged
6 tasks
urso
pushed a commit
that referenced
this pull request
Jul 23, 2020
…point for metricbeat (#20147) (cherry picked from commit 88cda01) Co-authored-by: Vijay Samuel <[email protected]>
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
What does this PR do?
Starttime of all metricsets on the
/datasetendpoint is always"0001-01-01T00:00:00.000Z". This PR fixes that.Why is it important?
Helps better debugging.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.