Cherry-pick #16493 to 7.x: Change the assertion for fileset modules#19869
Merged
adriansr merged 1 commit intoelastic:7.xfrom Jul 14, 2020
Merged
Cherry-pick #16493 to 7.x: Change the assertion for fileset modules#19869adriansr merged 1 commit intoelastic:7.xfrom
adriansr merged 1 commit intoelastic:7.xfrom
Conversation
In the previous module assertion we were checking the keys manually and if they didn't match we would just output the raw dictionary into the tests. This is not really useful because you have to either inspect them manually or user a local diff to know what exactly changes. This PR use DeepDiff to actually diff the two dictionary together and will output diff of the two dictionnary. This make debugging a little easier. (cherry picked from commit fa506a6)
adriansr
added
[zube]: In Review
backport
Team:Platforms
Contributor
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
Bot
added
needs_team
Contributor
Author
|
I need this for #19868 That PR requires the diff'ing for system-tests to ignore the order of array elements in comparisons. This was the case in master, but in 7.x we're currently using a simpler comparison method. |
sayden
approved these changes
Jul 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16493 to 7.x branch. Original message:
What does this PR do?
In the previous module assertion we were checking the keys manually and
if they didn't match we would just output the raw dictionary into the
tests. This is not really useful because you have to either inspect them
manually or user a local diff to know what exactly changes.
This PR use DeepDiff to actually diff the two dictionary together and
will output diff of the two dictionnary. This make debugging a little
easier.
Why is it important?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs