Skip to content

Conversation

@posquit0
Copy link
Contributor

@posquit0 posquit0 commented Jul 2, 2020

What does this PR do?

Fix typo in the docs of Heartbeat

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@posquit0 posquit0 requested a review from a team as a code owner July 2, 2020 05:21
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 2, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 2, 2020

❕ Build Aborted

The PR is not allowed to run in the CI yet

Pipeline View Test View Changes Artifacts

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Reason: The PR is not allowed to run in the CI yet

  • Start Time: 2020-07-13T09:45:01.910+0000

  • Duration: 5 min 18 sec

  • Commit: 0e320cc

Steps errors

Expand to view the steps failures

  • Name: Error signal
    • Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

    • Duration: 0 min 0 sec

    • Start Time: 2020-07-13T09:49:53.156+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-07-13T09:49:59.894Z] Stage "Elastic Agent x-pack Windows" skipped due to earlier failure(s)
[2020-07-13T09:49:59.910Z] Stage "Elastic Agent Mac OS X" skipped due to earlier failure(s)
[2020-07-13T09:49:59.923Z] Stage "Filebeat oss" skipped due to earlier failure(s)
[2020-07-13T09:49:59.956Z] Stage "Filebeat x-pack" skipped due to earlier failure(s)
[2020-07-13T09:49:59.973Z] Stage "Filebeat Mac OS X" skipped due to earlier failure(s)
[2020-07-13T09:49:59.987Z] Stage "Filebeat x-pack Mac OS X" skipped due to earlier failure(s)
[2020-07-13T09:50:00.004Z] Stage "Filebeat Windows" skipped due to earlier failure(s)
[2020-07-13T09:50:00.017Z] Stage "Filebeat x-pack Windows" skipped due to earlier failure(s)
[2020-07-13T09:50:00.040Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:00.048Z] Stage "Auditbeat oss Linux" skipped due to earlier failure(s)
[2020-07-13T09:50:00.064Z] Stage "Auditbeat crosscompile" skipped due to earlier failure(s)
[2020-07-13T09:50:00.148Z] Stage "Auditbeat oss Mac OS X" skipped due to earlier failure(s)
[2020-07-13T09:50:00.169Z] Stage "Auditbeat oss Windows" skipped due to earlier failure(s)
[2020-07-13T09:50:00.205Z] Stage "Auditbeat x-pack" skipped due to earlier failure(s)
[2020-07-13T09:50:00.230Z] Stage "Auditbeat x-pack Mac OS X" skipped due to earlier failure(s)
[2020-07-13T09:50:00.244Z] Stage "Auditbeat x-pack Windows" skipped due to earlier failure(s)
[2020-07-13T09:50:00.260Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:00.274Z] Stage "Libbeat x-pack" skipped due to earlier failure(s)
[2020-07-13T09:50:00.289Z] Stage "Metricbeat OSS Unit tests" skipped due to earlier failure(s)
[2020-07-13T09:50:00.306Z] Stage "Metricbeat OSS Integration tests" skipped due to earlier failure(s)
[2020-07-13T09:50:00.325Z] Stage "Metricbeat Python integration tests" skipped due to earlier failure(s)
[2020-07-13T09:50:00.342Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-07-13T09:50:00.353Z] Stage "Metricbeat crosscompile" skipped due to earlier failure(s)
[2020-07-13T09:50:00.379Z] Stage "Metricbeat Mac OS X" skipped due to earlier failure(s)
[2020-07-13T09:50:00.396Z] Stage "Metricbeat x-pack Mac OS X" skipped due to earlier failure(s)
[2020-07-13T09:50:00.420Z] Stage "Metricbeat Windows" skipped due to earlier failure(s)
[2020-07-13T09:50:00.438Z] Stage "Metricbeat x-pack Windows" skipped due to earlier failure(s)
[2020-07-13T09:50:00.457Z] Stage "Packetbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:00.466Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:00.476Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:00.484Z] Stage "Winlogbeat Windows x-pack" skipped due to earlier failure(s)
[2020-07-13T09:50:00.500Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:00.521Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:00.530Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-13T09:50:00.539Z] Stage "Kubernetes" skipped due to earlier failure(s)
[2020-07-13T09:50:00.954Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:00.970Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:00.984Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-07-13T09:50:01.006Z] Stage "Packetbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:01.033Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:01.046Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:01.062Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:01.074Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:01.087Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-13T09:50:04.880Z] Failed in branch Elastic Agent x-pack
[2020-07-13T09:50:04.919Z] Failed in branch Elastic Agent x-pack Windows
[2020-07-13T09:50:04.956Z] Failed in branch Elastic Agent Mac OS X
[2020-07-13T09:50:04.969Z] Failed in branch Filebeat oss
[2020-07-13T09:50:04.980Z] Failed in branch Filebeat x-pack
[2020-07-13T09:50:04.992Z] Failed in branch Filebeat Mac OS X
[2020-07-13T09:50:05.010Z] Failed in branch Filebeat x-pack Mac OS X
[2020-07-13T09:50:05.025Z] Failed in branch Filebeat Windows
[2020-07-13T09:50:05.066Z] Failed in branch Filebeat x-pack Windows
[2020-07-13T09:50:05.084Z] Failed in branch Auditbeat oss Linux
[2020-07-13T09:50:05.098Z] Failed in branch Auditbeat crosscompile
[2020-07-13T09:50:05.109Z] Failed in branch Auditbeat oss Mac OS X
[2020-07-13T09:50:05.124Z] Failed in branch Auditbeat oss Windows
[2020-07-13T09:50:05.141Z] Failed in branch Auditbeat x-pack
[2020-07-13T09:50:05.161Z] Failed in branch Auditbeat x-pack Mac OS X
[2020-07-13T09:50:05.180Z] Failed in branch Auditbeat x-pack Windows
[2020-07-13T09:50:05.191Z] Failed in branch Libbeat x-pack
[2020-07-13T09:50:05.213Z] Failed in branch Metricbeat OSS Unit tests
[2020-07-13T09:50:05.233Z] Failed in branch Metricbeat OSS Integration tests
[2020-07-13T09:50:05.260Z] Failed in branch Metricbeat Python integration tests
[2020-07-13T09:50:05.274Z] Failed in branch Metricbeat crosscompile
[2020-07-13T09:50:05.305Z] Failed in branch Metricbeat Mac OS X
[2020-07-13T09:50:05.323Z] Failed in branch Metricbeat x-pack Mac OS X
[2020-07-13T09:50:05.337Z] Failed in branch Metricbeat Windows
[2020-07-13T09:50:05.349Z] Failed in branch Metricbeat x-pack Windows
[2020-07-13T09:50:05.379Z] Failed in branch Winlogbeat Windows x-pack
[2020-07-13T09:50:05.401Z] Failed in branch Kubernetes
[2020-07-13T09:50:07.116Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:07.130Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:07.140Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-07-13T09:50:07.153Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:07.165Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:07.178Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-13T09:50:08.807Z] Failed in branch Packetbeat
[2020-07-13T09:50:08.820Z] Failed in branch dockerlogbeat
[2020-07-13T09:50:08.833Z] Failed in branch Journalbeat
[2020-07-13T09:50:08.835Z] Click here to forcibly terminate running steps
[2020-07-13T09:50:10.308Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:10.334Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:10.355Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-07-13T09:50:10.371Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-13T09:50:10.731Z] Failed in branch Metricbeat x-pack
[2020-07-13T09:50:10.745Z] Failed in branch Winlogbeat
[2020-07-13T09:50:11.859Z] Failed in branch Heartbeat
[2020-07-13T09:50:11.871Z] Failed in branch Libbeat
[2020-07-13T09:50:11.882Z] Failed in branch Functionbeat
[2020-07-13T09:50:11.882Z] Stage "Generators" skipped due to earlier failure(s)
[2020-07-13T09:50:12.285Z] Failed in branch Generators
[2020-07-13T09:50:16.860Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-19585
[2020-07-13T09:50:17.372Z] [INFO] getVaultSecret: Getting secrets
[2020-07-13T09:50:17.695Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-13T09:50:20.340Z] + chmod 755 generate-build-data.sh
[2020-07-13T09:50:20.340Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19585/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19585/runs/1 ABORTED 318094
[2020-07-13T09:50:20.340Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19585/runs/1/steps/?limit=10000 -o steps-info.json
[2020-07-13T09:50:21.683Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19585/runs/1/tests/?status=FAILED -o tests-errors.json
[2020-07-13T09:50:21.934Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19585/runs/1/log/ -o pipeline-log.txt

@andresrc andresrc added docs Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Jul 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 2, 2020
@andrewvc
Copy link
Contributor

andrewvc commented Jul 6, 2020

Thanks for the PR!

Jenkins, test this please

@andrewvc andrewvc self-assigned this Jul 6, 2020
@andrewvc andrewvc self-requested a review July 6, 2020 21:54
@andrewvc
Copy link
Contributor

andrewvc commented Jul 6, 2020

jenkins, please test this

@kaiyan-sheng
Copy link
Contributor

jenkins run the tests

@posquit0
Copy link
Contributor Author

jenkins please test

@posquit0
Copy link
Contributor Author

jenkins run the tests

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please accept my apologies for the delayed review. I will make sure this gets backported to the appropriate versions.

@dedemorton dedemorton merged commit 5a6f830 into elastic:7.8 Oct 21, 2020
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Oct 21, 2020
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Oct 21, 2020
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Oct 21, 2020
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Oct 21, 2020
@dedemorton dedemorton mentioned this pull request Oct 21, 2020
dedemorton added a commit that referenced this pull request Oct 21, 2020
Co-authored-by: Byungjin Park (BJ) <[email protected]>
dedemorton added a commit that referenced this pull request Oct 21, 2020
Co-authored-by: Byungjin Park (BJ) <[email protected]>
dedemorton added a commit that referenced this pull request Oct 21, 2020
Co-authored-by: Byungjin Park (BJ) <[email protected]>
dedemorton added a commit that referenced this pull request Oct 21, 2020
Co-authored-by: Byungjin Park (BJ) <[email protected]>
v1v added a commit to v1v/beats that referenced this pull request Oct 22, 2020
…uild-retry-docker-if-error-packaging

* upstream/master:
  Fix the url of reviewdog (elastic#21981)
  revert WSS process reporting for windows (elastic#22055)
  Fix typo (elastic#19585) (elastic#22061)
v1v added a commit to v1v/beats that referenced this pull request Oct 22, 2020
* upstream/master: (27 commits)
  chore: use ubuntu 18 as linux agent (elastic#22084)
  docs: Prepare Changelog for 7.9.3 (elastic#22073) (elastic#22075)
  docs: Prepare Changelog for 6.8.13 (elastic#22072) (elastic#22079)
  [build][packaging] Add resilience when docker build (elastic#22050)
  Fix the url of reviewdog (elastic#21981)
  revert WSS process reporting for windows (elastic#22055)
  Fix typo (elastic#19585) (elastic#22061)
  [Ingest Manager] Use ML_SYSTEM to detect if agent is running as a service (elastic#21884)
  Prevent log input from sending duplicate messages due to file renaming (elastic#21911)
  feat: package aliases for snapshots (elastic#21960)
  [DOC] Add firewall as possible troubleshooting issue (elastic#21743)
  [Filebeat] Add max_number_of_messages config parameter for S3 input (elastic#21993)
  [Elastic Agent] Fix missing elastic_agent event data  (elastic#21994)
  Document auditbeat system process module config (elastic#21766)
  Update links (elastic#22012)
  dynamically find librpm (elastic#21936)
  Fix Istio docs (elastic#22019)
  [beats-tester][packaging] store packages in another location (elastic#21903)
  [Kubernetes] Remove redundant dockersock volume mount (elastic#22009)
  [Ingest Manager] Always try snapshot repo for agent upgrade (elastic#21951)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 26, 2020
…beats into feature/support-flaky-test-analyser

* 'feature/support-flaky-test-analyser' of github.com:v1v/beats: (40 commits)
  [CI] support windows-10 (elastic#19804)
  Use default config when creating the input (elastic#22126)
  Change x509 mappings from file. to tls.server. (elastic#22097)
  Add fleet settings image (elastic#22065)
  Edit 7.9.3 changelog (elastic#22117)
  Edit 6.8.13 release notes (elastic#22120)
  Incorporate librpm fix feedback (elastic#22098)
  [libbeat] Add more disk queue unit tests and fix a size-check bug (elastic#22107)
  docs: move kerberos include (elastic#22109)
  Check context.Canceled and fix s3 input config (elastic#22036)
  Add max_number_of_messages into aws filebeat fileset vars (elastic#22057)
  Remove suricata.eve.timestamp alias (elastic#22095)
  [Ingest Manager] Use symlink path for reexecutions (elastic#21835)
  chore: use ubuntu 18 as linux agent (elastic#22084)
  docs: Prepare Changelog for 7.9.3 (elastic#22073) (elastic#22075)
  docs: Prepare Changelog for 6.8.13 (elastic#22072) (elastic#22079)
  [build][packaging] Add resilience when docker build (elastic#22050)
  Fix the url of reviewdog (elastic#21981)
  revert WSS process reporting for windows (elastic#22055)
  Fix typo (elastic#19585) (elastic#22061)
  ...
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants