Introduce clean_removed #1922
Merged
Introduce clean_removed #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // States is older then ttl | ||
| if int64(time.Since(state.Timestamp).Nanoseconds()/int64(time.Microsecond)) > state.Ttl { |
There was a problem hiding this comment.
can we transform state.TTL to be time.Duration. Not happy with conversions like to nanos and devide by Microseconds. Which unit is TTL in?
There was a problem hiding this comment.
I just converted and now realised that it seems like this breaks the json conversion. Any trick here?
TTL time.Duration `json:"ttl"`
There was a problem hiding this comment.
time.Duration changes were done in #1915
| @@ -56,6 +56,7 @@ https://github.com/elastic/beats/compare/v5.0.0-alpha3...master[Check the HEAD d | |||
| - Introduce close_removed and close_renamed harvester options {issue}1600[1600] | |||
| - Introduce close_eof harvester options {issue}1600[1600] | |||
|
|
|||
| - Add clean_removed config option | |||
| #close_eof: false | ||
|
|
||
| # Files for the modification data is older then clean_older the state from the registry is removed | ||
| # By default this is disabled. | ||
| #clean_older: 0 | ||
|
|
||
| # Removes the state for file which cannot be found on disk anymore immidiately |
ruflin
force-pushed
the
fb-clean-removed
branch
3 times, most recently
from
43a9bfe
to
b4763ba
Compare
| @@ -93,7 +93,7 @@ func (s *States) Cleanup() { | |||
|
|
|||
| for _, state := range s.states { | |||
| ttl := state.TTL | |||
| if ttl >= 0 && currentTime.Sub(state.Timestamp) > ttl { | |||
| if ttl >= 0 && currentTime.Sub(state.Timestamp) >= ttl { | |||
There was a problem hiding this comment.
how about: if ttl==0 || currentTime.Sub(state.Timestamp) > ttl ?
There was a problem hiding this comment.
I would be ok with ttl==0 || currentTime.Sub(state.Timestamp) >= ttl I had one test case where state.Timestamp == currentTimestamp ! Not sure how this was able to happen (windows ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.