Skip to content

Cherry-pick #18523 to 7.x: Add new fields to HAProxy module of Metricbeat #18893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

Cherry-pick #18523 to 7.x: Add new fields to HAProxy module of Metricbeat #18893

merged 1 commit into from
Jun 2, 2020

Conversation

@kvch
Copy link
Contributor

@kvch kvch commented Jun 2, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #18523 to 7.x branch. Original message:

What does this PR do?

This PR adds missing HAProxy metrics to Metricbeat.

Why is it important?

With new releases HAProxy exposed more metrics, previously not available in Metricbeat.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kvch
Add new fields to HAProxy module of Metricbeat (elastic#18523)
0fcda91 
## What does this PR do?

This PR adds missing HAProxy metrics to Metricbeat.

## Why is it important?

With new releases HAProxy exposed more metrics, previously not available in Metricbeat.
(cherry picked from commit 153caaf)
@kvch kvch added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Jun 2, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 2, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 2, 2020

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 2, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 2, 2020

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18893 opened]

  • Start Time: 2020-06-02T13:08:46.378+0000

  • Duration: 60 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 2077
Skipped 467
Total 2544

Steps errors

Expand to view the steps failures

  • Name: Mage build test

    • Description: mage build test

    • Duration: 10 min 1 sec

    • Start Time: 2020-06-02T13:36:38.237+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-06-02T14:08:03.691Z] 		at hudson.FilePath.validateAntFileMask(FilePath.java:2684)
[2020-06-02T14:08:03.691Z] 		at hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:265)
[2020-06-02T14:08:03.691Z] 		at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:80)
[2020-06-02T14:08:03.691Z] 		at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:67)
[2020-06-02T14:08:03.691Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
[2020-06-02T14:08:03.691Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[2020-06-02T14:08:03.691Z] 		at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[2020-06-02T14:08:03.691Z] 		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[2020-06-02T14:08:03.691Z] 		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2020-06-02T14:08:03.691Z] Caused: hudson.FilePath$TunneledInterruptedException
[2020-06-02T14:08:03.691Z] 	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3075)
[2020-06-02T14:08:03.691Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:212)
[2020-06-02T14:08:03.691Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
[2020-06-02T14:08:03.691Z] 	at hudson.remoting.Request$2.run(Request.java:369)
[2020-06-02T14:08:03.691Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
[2020-06-02T14:08:03.691Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[2020-06-02T14:08:03.691Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[2020-06-02T14:08:03.692Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2020-06-02T14:08:03.692Z] 	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:93)
[2020-06-02T14:08:03.692Z] Caused: java.lang.InterruptedException: java.lang.InterruptedException: no matches found within 10000
[2020-06-02T14:08:03.692Z] 	at hudson.FilePath.act(FilePath.java:1071)
[2020-06-02T14:08:03.692Z] 	at hudson.FilePath.act(FilePath.java:1058)
[2020-06-02T14:08:03.692Z] 	at hudson.FilePath.validateAntFileMask(FilePath.java:2684)
[2020-06-02T14:08:03.692Z] 	at hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:265)
[2020-06-02T14:08:03.692Z] 	at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:80)
[2020-06-02T14:08:03.692Z] 	at org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:67)
[2020-06-02T14:08:03.692Z] 	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
[2020-06-02T14:08:03.692Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[2020-06-02T14:08:03.692Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[2020-06-02T14:08:03.692Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[2020-06-02T14:08:03.692Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2020-06-02T14:08:03.692Z] 	at java.lang.Thread.run(Thread.java:748)
[2020-06-02T14:08:03.692Z] No artifacts found that match the file pattern "**/build/TEST*.out". Configuration error?
[2020-06-02T14:08:04.155Z] + curl -sSLo codecov https://codecov.io/bash
[2020-06-02T14:08:04.413Z] + FILE=auditbeat/build/coverage/full.cov
[2020-06-02T14:08:04.413Z] + [ -f auditbeat/build/coverage/full.cov ]
[2020-06-02T14:08:04.413Z] + FILE=filebeat/build/coverage/full.cov
[2020-06-02T14:08:04.413Z] + [ -f filebeat/build/coverage/full.cov ]
[2020-06-02T14:08:04.413Z] + FILE=heartbeat/build/coverage/full.cov
[2020-06-02T14:08:04.413Z] + [ -f heartbeat/build/coverage/full.cov ]
[2020-06-02T14:08:04.413Z] + FILE=libbeat/build/coverage/full.cov
[2020-06-02T14:08:04.413Z] + [ -f libbeat/build/coverage/full.cov ]
[2020-06-02T14:08:04.413Z] + FILE=metricbeat/build/coverage/full.cov
[2020-06-02T14:08:04.413Z] + [ -f metricbeat/build/coverage/full.cov ]
[2020-06-02T14:08:04.413Z] + FILE=packetbeat/build/coverage/full.cov
[2020-06-02T14:08:04.413Z] + [ -f packetbeat/build/coverage/full.cov ]
[2020-06-02T14:08:04.413Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-06-02T14:08:04.413Z] + [ -f winlogbeat/build/coverage/full.cov ]
[2020-06-02T14:08:04.413Z] + FILE=journalbeat/build/coverage/full.cov
[2020-06-02T14:08:04.413Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-06-02T14:08:07.658Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18893/src/github.com/elastic/beats
[2020-06-02T14:08:07.991Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-06-02T14:08:08.014Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18893/src/github.com/elastic/beats/Lint
[2020-06-02T14:08:08.171Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18893/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-06-02T14:08:08.329Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18893/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-06-02T14:08:08.484Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18893/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-06-02T14:08:08.647Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18893/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-06-02T14:08:08.799Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18893/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-06-02T14:08:08.951Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18893/src/github.com/elastic/beats/Metricbeat-Windows
[2020-06-02T14:08:09.096Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18893/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-06-02T14:08:09.565Z] + cat
[2020-06-02T14:08:09.565Z] + /usr/local/bin/runbld ./runbld-script
[2020-06-02T14:08:09.565Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-06-02T14:08:16.162Z] runbld>>> runbld started
[2020-06-02T14:08:16.162Z] runbld>>> 1.6.11/a66728ff8f4356963772e6e6d2069392fa06acbe
[2020-06-02T14:08:18.073Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-18893' in order of occurrence in the config (last value wins).
[2020-06-02T14:08:19.014Z] runbld>>> Debug logging enabled.
[2020-06-02T14:08:19.014Z] runbld>>> Storing result
[2020-06-02T14:08:19.275Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-06-02T14:08:19.275Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200602140818-9E0B3760
[2020-06-02T14:08:19.275Z] runbld>>> Adding system facts.
[2020-06-02T14:08:20.215Z] runbld>>> Adding vcs info for the latest commit:  0fcda9128aad61a83362b05a4bd2a8a5d1b3cdb1
[2020-06-02T14:08:20.476Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-06-02T14:08:20.476Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-06-02T14:08:20.476Z] + echo 'Processing JUnit reports with runbld...'
[2020-06-02T14:08:20.476Z] Processing JUnit reports with runbld...
[2020-06-02T14:08:21.049Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-06-02T14:08:21.049Z] runbld>>> DURATION: 15ms
[2020-06-02T14:08:21.049Z] runbld>>> STDOUT: 40 bytes
[2020-06-02T14:08:21.049Z] runbld>>> STDERR: 49 bytes
[2020-06-02T14:08:21.049Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-06-02T14:08:21.049Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18893/src/github.com/elastic/beats
[2020-06-02T14:08:22.433Z] runbld>>> Storing build metadata: 
[2020-06-02T14:08:22.433Z] runbld>>> Adding test report.
[2020-06-02T14:08:22.433Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18893/src/github.com/elastic/beats
[2020-06-02T14:08:23.375Z] runbld>>> Found 10 test output files
[2020-06-02T14:08:24.341Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 2544 Skipped: 413
[2020-06-02T14:08:24.602Z] runbld>>> Storing result
[2020-06-02T14:08:24.602Z] runbld>>> FAILURES: 0
[2020-06-02T14:08:24.862Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-06-02T14:08:24.862Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200602140818-9E0B3760
[2020-06-02T14:08:24.862Z] runbld>>> Email notification disabled by environment variable.
[2020-06-02T14:08:24.862Z] runbld>>> Slack notification disabled by environment variable.
[2020-06-02T14:08:31.166Z] Running on worker-395930 in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18893
[2020-06-02T14:08:31.297Z] [INFO] getVaultSecret: Getting secrets
[2020-06-02T14:08:31.356Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-06-02T14:08:33.610Z] + chmod 755 generate-build-data.sh
[2020-06-02T14:08:33.611Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18893/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18893/runs/1 FAILURE 3585774
[2020-06-02T14:08:33.611Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18893/runs/1/steps/?limit=10000 -o steps-info.json
[2020-06-02T14:08:34.332Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18893/runs/1/tests/?status=FAILED -o tests-errors.json

@kvch kvch merged commit f2112c3 into elastic:7.x Jun 2, 2020
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sayden sayden sayden approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Team:Services (Deprecated) Label for the former Integrations-Services team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kvch @elasticmachine @sayden