Skip to content

Cherry-pick #18844 to 7.x: When not port are specified and the https is used fa… #18874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

Cherry-pick #18844 to 7.x: When not port are specified and the https is used fa… #18874

merged 1 commit into from
Jun 2, 2020

Conversation

@michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Jun 1, 2020

Cherry-pick of PR #18844 to 7.x branch. Original message:

What does this PR do?

Provides default value for kibana client when https is used but no port specified

Why is it important?

eases up configuration and makes behavior more predictable

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas
[Ingest Manager] When not port are specified and the https is used fa…
595e376 
…llback to 443 (elastic#18844)

[Ingest Manager] When not port are specified and the https is used fallback to 443 (elastic#18844)
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 1, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 1, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 1, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18874 opened]

  • Start Time: 2020-06-01T07:27:46.212+0000

  • Duration: 31 min 13 sec

blakerouse
blakerouse approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit 954bff4 into elastic:7.x Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

No one assigned

Labels

backport enhancement Ingest Management:beta1 Group issues for ingest management beta1 review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalpristas @elasticmachine @blakerouse