Avoid duplicate names in dynamic_templates #18849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple dynamic templates are detected for the same field, add the matching type to the template name for uniqueness. closes elastic#17203
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
exekias
suggested changes
Jun 1, 2020
Contributor
exekias
left a comment
exekias
left a comment
There was a problem hiding this comment.
Change LGTM, thank you for submitting it! could you please add a changelog entry?
Contributor
Author
|
test failures seem unrelated |
exekias
approved these changes
Jun 2, 2020
exekias
added
the
needs_backport
simitt
added a commit
to simitt/beats
that referenced
this pull request
Jun 2, 2020
When multiple dynamic templates are detected for the same field, add the matching type to the template name for uniqueness. closes elastic#17203
2 tasks
simitt
added a commit
that referenced
this pull request
Jun 2, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jun 2, 2020
…-stage-level * upstream/master: [CI] Fix permissions should not fail (elastic#18899) Revert "Allow the Docker image to be run with a random user id (elastic#12905)" (elastic#18872) Add new fields to HAProxy module of Metricbeat (elastic#18523) Avoid duplicate names in dynamic_templates (elastic#18849)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When multiple dynamic templates are detected for the same field, add the
matching type to the template name for uniqueness.
Why is it important?
As described in #17203 (comment) the APM Server depends on allowing multiple dynamic templates for the same field, with different matching types. Therefore this PR takes care of adding some unique part to the name rather than failing with an error.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
This can be tested with APM Server as it creates multiple dynamic templates for the
labelsfield.go mod edit -replace github.com/elastic/beats/v7=<path-to-your-local-beats-repo>.make update apm-server && ./apm-server -e -E setup.template.overwrite=trueapm-8.0.0and search forlabels_string,labels_booleanandlabels_*.Related issues
Screenshots