-
Notifications
You must be signed in to change notification settings - Fork 5k
Don't send bulk structure, if empty #18747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't send bulk structure, if empty #18747
Conversation
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
|
Pinging @elastic/integrations-services (Team:Services) |
💔 Build FailedExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
chrisronline
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm not seeing the bulk data structure when it's not returned by ES.
|
jenkins, run tests please |
💔 Build FailedExpand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
|
CI failures are unrelated and should be fixed once #18777 is merged. Merging. |
What does this PR do?
Omits the
index_stats.total.bulkandindex_stats.primaries.bulkfields if they are empty.Why is it important?
We only collect
bulkmetrics from versions of Elasticsearch that offer them in theGET _statsAPI. For other versions, there's no point in reporting emptybulkmetrics.