Skip to content

[7.x] Followup to 12606 (#18316) #18520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2020
Merged

[7.x] Followup to 12606 (#18316) #18520

merged 2 commits into from
May 19, 2020

Conversation

@ycombinator
Copy link
Contributor

@ycombinator ycombinator commented May 14, 2020

Backports the following commits to 7.x:

@ycombinator ycombinator added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels May 14, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 14, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented May 14, 2020

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 14, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented May 14, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 6612
Skipped 1053
Total 7665

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Result: FAILURE

    • Duration: 2 min 22 sec

    • Start Time: 2020-05-18T10:34:51.056+0000

    • log

sayden
sayden reviewed May 18, 2020
View reviewed changes
CHANGELOG-developer.next.asciidoc Outdated
Copy link
Contributor

@sayden sayden May 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this line is required AFAIC from here https://github.com/elastic/beats/pull/18316/files

@ycombinator
Followup to 12606 (#18316)
d3e4376 
* Adding developer CHANGELOG entry

* Refactoring: extracting helper method

* Adding unit tests

* Consolidate event metadata field constants

* Use events.GetMetaStringValue

* Implement op_type values as enum

* Add doc strings

* Deference event pointer

* Renaming op type consts and breaking them out into own block

* Renaming type

* Using stringer

* Using go idiom instead of if-else

* Adding default op type

* Empty string for default

* Store op type enum, not string, in event metadata

* Using events.GetMetaStringValue

* Updating dev CHANGELOG entry

* Allow for op_type metadata field to be set as either string or enum

* No need for .String()

* Handle missing key case gracefully

* Update unit tests

* Update developer CHANGELOG entry
@ycombinator
Fixing up CHANGELOG
4367248
sayden
sayden approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@ycombinator ycombinator merged commit fe1a9a9 into elastic:7.x May 19, 2020
@ycombinator ycombinator deleted the backport/7.x/pr-18316 branch May 19, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sayden sayden sayden approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Team:Services (Deprecated) Label for the former Integrations-Services team [zube]: Done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ycombinator @elasticmachine @sayden