Skip to content

[Elastic-Agent] Moved stream.* fields to top of event#17858

Merged
michalpristas merged 6 commits intoelastic:masterfrom
michalpristas:agent-top-level-streams
Apr 22, 2020
Merged

[Elastic-Agent] Moved stream.* fields to top of event#17858
michalpristas merged 6 commits intoelastic:masterfrom
michalpristas:agent-top-level-streams

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented Apr 21, 2020

What does this PR do?

Modifies generated add_fields processor to include stream fields to top level not under fields.*

Why is it important?

It is required

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ingest-management (Project:fleet)

Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could we have also some test for this as a follow up to make sure our events look as expected long term. Not sure how this fits into our current testing frameworks.

Copy link
Copy Markdown
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph ph added the needs_backport PR is waiting to be backported to other branches. label Apr 21, 2020
@ph ph changed the title [Agent] Moved stream.* fields to top of event [Elastic-Agent] Moved stream.* fields to top of event Apr 21, 2020
@michalpristas michalpristas merged commit 677d2e2 into elastic:master Apr 22, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request Apr 22, 2020
[Elastic-Agent] Moved stream.* fields to top of event (elastic#17858)
michalpristas added a commit that referenced this pull request Apr 22, 2020
[Elastic-Agent] Moved stream.* fields to top of event (#17858)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug needs_backport PR is waiting to be backported to other branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants