Fix initialization of Logstash service URL#17497
Merged
ycombinator merged 17 commits intoelastic:masterfrom Apr 7, 2020
ycombinator:mb-ls-xp-init-bugfix
Merged
Fix initialization of Logstash service URL#17497ycombinator merged 17 commits intoelastic:masterfrom ycombinator:mb-ls-xp-init-bugfix
ycombinator merged 17 commits intoelastic:masterfrom
ycombinator:mb-ls-xp-init-bugfix
Conversation
ycombinator
added
bug
needs_backport
Contributor
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
ycombinator
added
v7.7.1
test-plan
zube
bot
added
[zube]: Inbox
[zube]: In Review
and removed
[zube]: In Review
[zube]: Inbox
labels
ycombinator
commented
Apr 6, 2020
kvch
reviewed
Apr 6, 2020
ycombinator
commented
Apr 6, 2020
Contributor
Author
|
Temporarily taking this PR out of review. I want to look into automating the testing for this bugfix. |
mtojek
approved these changes
Apr 7, 2020
Contributor
There was a problem hiding this comment.
Actually I would cover this method with a unit test to shorten debugging time (missing query parameters, etc.).
I'm not sure if the method name is not misleading (looks like a setter), but it enables Graph API, right?
Contributor
Author
|
@mtojek Thanks for the review. I've addressed your feedback. Mind taking another look when you get a chance, please? |
mtojek
approved these changes
Apr 7, 2020
Contributor
Author
|
CI failures are unrelated. Merging. |
This was referenced Apr 7, 2020
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the initialization of the Logstash service's URI in the
logstash/node_statsmetricset.Why is it important?
Prior to this fix, when the
logstash-xpackMetricbeat module was enabled, users would need to start up Metricbeat after Logstash was started up in order for thelogstash/node_statsmetricset to report the correct data.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues