Remove Makefile which ruins builds from vendor #17013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
added
[zube]: In Review
Team:Services
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
jsoriano
approved these changes
Mar 16, 2020
jsoriano
approved these changes
Mar 17, 2020
kvch
added a commit
to kvch/beats
that referenced
this pull request
Mar 17, 2020
This PR adds the option to remove files from the vendor folder during `mage update`. `yacc` is triggered from time to time when `mage vendor` copies files in a particular order. It leads to build failures unexpectedly. (cherry picked from commit 9370128)
kvch
added
v7.7.0
and removed
needs_backport
kvch
added a commit
that referenced
this pull request
Mar 17, 2020
This PR adds the option to remove files from the vendor folder during `mage update`. `yacc` is triggered from time to time when `mage vendor` copies files in a particular order. It leads to build failures unexpectedly. (cherry picked from commit 9370128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the option to remove files from the vendor folder during
mage update.Why is it important?
yaccis triggered from time to time whenmage vendorcopies files in a particular order. It leads to build failures unexpectedly.Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works