Skip to content

Generate haproxy module docs#16776

Merged
ycombinator merged 1 commit intoelastic:masterfrom
ycombinator:mb-haproxy-gen-docs
Mar 4, 2020
Merged

Generate haproxy module docs#16776
ycombinator merged 1 commit intoelastic:masterfrom
ycombinator:mb-haproxy-gen-docs

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

Completes the change started in #16703.

@ycombinator ycombinator requested a review from dedemorton March 3, 2020 21:10
@ycombinator ycombinator added docs needs_backport PR is waiting to be backported to other branches. review v8.0.0 labels Mar 3, 2020
Copy link
Copy Markdown
Contributor

@mikemadden42 mikemadden42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dedemorton
Copy link
Copy Markdown
Contributor

Oh that's weird because my local branch has the changed docs file. But I guess the PR didn't show it was changed because I created my PR before Steffen reverted the original PR that broke the CI. Anyhow, this looks good. Thanks for catching it!

@ycombinator
Copy link
Copy Markdown
Contributor Author

CI failures are unrelated and also happening on master. Merging.

@ycombinator ycombinator merged commit f686982 into elastic:master Mar 4, 2020
@ycombinator ycombinator deleted the mb-haproxy-gen-docs branch March 4, 2020 00:13
ycombinator added a commit that referenced this pull request Mar 5, 2020
…16801)

* [docs] Add username and password to haproxy example (#16703)

* Generate haproxy module docs (#16776)

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
ycombinator added a commit that referenced this pull request Mar 6, 2020
…16800)

* [docs] Add username and password to haproxy example (#16703)

* Generate haproxy module docs (#16776)

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants