Move azure module to GA#16754
Merged
narph merged 10 commits intoelastic:masterfrom Mar 4, 2020
Merged
Conversation
narph
added
Team:Integrations
narph
added
[zube]: In Review
needs_backport
exekias
approved these changes
Mar 4, 2020
Contributor
exekias
left a comment
exekias
left a comment
There was a problem hiding this comment.
just some minor comments
Comment on lines
-20
to
+23
| ClientID string `config:"client_id" validate:"required"` | ||
| ClientId string `config:"client_id" validate:"required"` | ||
| ClientSecret string `config:"client_secret" validate:"required"` | ||
| TenantID string `config:"tenant_id" validate:"required"` | ||
| SubscriptionID string `config:"subscription_id" validate:"required"` | ||
| TenantId string `config:"tenant_id" validate:"required"` | ||
| SubscriptionId string `config:"subscription_id" validate:"required"` |
Contributor
There was a problem hiding this comment.
Why these changes? I don't think there is anything wrong with ID
Contributor
Author
There was a problem hiding this comment.
there was a mix of Id and ID in the code so I went with most used for consistency
| "tenant_id": tenantId, | ||
| "subscription_id": subscriptionId, | ||
| func TestData(t *testing.T) { | ||
| config, err := test.GetConfig("container_instance") |
Contributor
Author
|
cc @sorantis, just a heads up on the changes, dashboards have been updated as well |
narph
added a commit
to narph/beats
that referenced
this pull request
Mar 4, 2020
* work on GA * mage fmt * fix * work on tests * fix * work on tests * generate from test (cherry picked from commit 1894441)
narph
added a commit
that referenced
this pull request
Mar 4, 2020
narph
added
v7.7.0
and removed
needs_backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix some of the points in #16024
azure.resource.nametocloud.instance.namecloud.instance.idandcloud.machine.type(mapping the resource size forcompute_vmandcompute_vm_scaleset)data.jsonfiles