Cherry-pick #15059 to 7.x: Add metricbeat iis module#16690
Merged
narph merged 3 commits intoelastic:7.xfrom Mar 2, 2020
Merged
Cherry-pick #15059 to 7.x: Add metricbeat iis module#16690narph merged 3 commits intoelastic:7.xfrom
narph merged 3 commits intoelastic:7.xfrom
Conversation
* created iis module * work in progress * iis changes * add iis module * light * work on build * work on build * build * fmt update * temp * work on website * temp * temp * manifest changes * temp * temp * work on wp * adding application pool metricset * wmi option * test * work on apppool * work on app pool * work on website metricset * work on tests * Work on website * work on website * work on website * perfmon fix * work on websie * update config * feedback * work on feedback * temp * ecs * temp * add counters (cherry picked from commit 8be4589)
kaiyan-sheng
approved these changes
Mar 2, 2020
Contributor
kaiyan-sheng
left a comment
There was a problem hiding this comment.
It seems to be missing a changelog in the original PR. Other than that, this looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #15059 to 7.x branch. Original message:
Related issue #13072
Reusing the pdh query (in perfmon) to retrieve the iis specific counters.
Initial implementation contains 2 metricsets: