Skip to content

Cherry-pick #16658 to 7.x: Remove feature.Describer and enhance Details#16674

Merged
urso merged 1 commit intoelastic:7.xfrom
urso:backport_16658_7.x
Feb 28, 2020
Merged

Cherry-pick #16658 to 7.x: Remove feature.Describer and enhance Details#16674
urso merged 1 commit intoelastic:7.xfrom
urso:backport_16658_7.x

Conversation

@urso
Copy link
Copy Markdown

@urso urso commented Feb 27, 2020

Cherry-pick of PR #16658 to 7.x branch. Original message:

  • Refactoring

What does this PR do?

  • Remove redundant Describer interface and handle Details as a value struct. Details will be passed by value and is not really modifiable.
  • Adds a 'Deprecated' bool flag to the Details type.

Why is it important?

I wanted to reuse some parts of the features package, but found it rather complex. Still feature.Details I'd like to keep :)

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@urso urso added backport review Team:Services (Deprecated) Label for the former Integrations-Services team labels Feb 27, 2020
@urso urso requested a review from ph February 27, 2020 19:54
Copy link
Copy Markdown
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urso urso merged commit 169c010 into elastic:7.x Feb 28, 2020
@urso urso deleted the backport_16658_7.x branch February 28, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport review Team:Services (Deprecated) Label for the former Integrations-Services team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants