Skip to content

Fix a formatting issues in the configuration related to ca_sha256#16673

Merged
ph merged 2 commits intoelastic:masterfrom
ph:small/config-issues
Feb 28, 2020
Merged

Fix a formatting issues in the configuration related to ca_sha256#16673
ph merged 2 commits intoelastic:masterfrom
ph:small/config-issues

Conversation

@ph
Copy link
Copy Markdown
Contributor

@ph ph commented Feb 27, 2020

What does this PR do?

Why is it important?

Add the missing ":" at the end of the option in the YAML.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph ph requested a review from urso February 27, 2020 19:35
@ph ph requested review from a team as code owners February 27, 2020 19:35
@ph ph self-assigned this Feb 27, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 27, 2020

Pinging @elastic/ingest (Project:fleet)

@ph ph requested a review from ruflin February 27, 2020 19:45
@ph ph mentioned this pull request Feb 27, 2020
Merged
7 tasks
@ph
Copy link
Copy Markdown
Contributor Author

ph commented Feb 28, 2020 •
edited
Loading

jenkins test this

1 similar comment
@ph
Copy link
Copy Markdown
Contributor Author

ph commented Feb 28, 2020

jenkins test this

@ph
Copy link
Copy Markdown
Contributor Author

ph commented Feb 28, 2020

I've rekick jenkins 3 jobs didn't get executed because of lost connection?

@ph ph merged commit 297fde4 into elastic:master Feb 28, 2020
@ph ph added the needs_backport PR is waiting to be backported to other branches. label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruflin ruflin Awaiting requested review from ruflin

1 more reviewer

@urso urso urso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ph ph

Labels

needs_backport PR is waiting to be backported to other branches. review [zube]: In Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ph @elasticmachine @urso