[Libbeat] Use *logp.Logger in libbeat processors#16654
Merged
kaiyan-sheng merged 6 commits intoelastic:masterfrom Mar 2, 2020
kaiyan-sheng:logp-cloud
Merged
[Libbeat] Use *logp.Logger in libbeat processors#16654kaiyan-sheng merged 6 commits intoelastic:masterfrom kaiyan-sheng:logp-cloud
kaiyan-sheng merged 6 commits intoelastic:masterfrom
kaiyan-sheng:logp-cloud
Conversation
66 tasks
kaiyan-sheng
added
needs_backport
|
Thanks for the help! I think the build is broken because of this |
Contributor
Author
Yep! Thanks! I think I fixed several unit tests (not sure if I'm still missing any, CI will tell 😬). |
urso
approved these changes
Feb 28, 2020
kaiyan-sheng
added
v7.7.0
and removed
needs_backport
Contributor
Author
|
CI failure is caused by #16718, not related to this PR. |
kaiyan-sheng
pushed a commit
that referenced
this pull request
Mar 3, 2020
andresrc
added
Team:Integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to improve logging in libbeat processors by add
*logp.Loggerin structures, replacelogp.Debug/Info/Warn/...withfvariants and remove debug parameters.Please see #15699 for more details.