Fix timeout option of Functionbeat#16287
Merged
kvch merged 3 commits intoelastic:masterfrom Feb 25, 2020
Merged
Conversation
kvch
added
needs_backport
andresrc
added
[zube]: Inbox
[zube]: In Review
and removed
[zube]: In Review
[zube]: Inbox
labels
Contributor
Author
|
Failing tests are unrelated. |
fearful-symmetry
approved these changes
Feb 25, 2020
5 tasks
kvch
removed
the
needs_backport
kvch
added a commit
to kvch/beats
that referenced
this pull request
Feb 25, 2020
## What does this PR do? This PR changes the type of `timeout` option of GCP functions to `string` from `time.Duration`. ## Why is it important? The option was parsed as `time.Duration` and then converted to `string` when creating the payload to upload a function. However, the format of the converted value was not accepted by GCP. This prevented users from setting the timeout from the manager. (cherry picked from commit 6cc308d)
5 tasks
kvch
added a commit
to kvch/beats
that referenced
this pull request
Feb 25, 2020
## What does this PR do? This PR changes the type of `timeout` option of GCP functions to `string` from `time.Duration`. ## Why is it important? The option was parsed as `time.Duration` and then converted to `string` when creating the payload to upload a function. However, the format of the converted value was not accepted by GCP. This prevented users from setting the timeout from the manager. (cherry picked from commit 6cc308d)
kvch
added a commit
that referenced
this pull request
Feb 25, 2020
## What does this PR do? This PR changes the type of `timeout` option of GCP functions to `string` from `time.Duration`. ## Why is it important? The option was parsed as `time.Duration` and then converted to `string` when creating the payload to upload a function. However, the format of the converted value was not accepted by GCP. This prevented users from setting the timeout from the manager. (cherry picked from commit 6cc308d)
kvch
added a commit
that referenced
this pull request
Feb 25, 2020
## What does this PR do? This PR changes the type of `timeout` option of GCP functions to `string` from `time.Duration`. ## Why is it important? The option was parsed as `time.Duration` and then converted to `string` when creating the payload to upload a function. However, the format of the converted value was not accepted by GCP. This prevented users from setting the timeout from the manager. (cherry picked from commit 6cc308d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the type of
timeoutoption of GCP functions tostringfromtime.Duration.Why is it important?
The option was parsed as
time.Durationand then converted tostringwhen creating the payload to upload a function. However, the format of the converted value was not accepted by GCP. This prevented users from setting the timeout from the manager.Checklist
How to test this PR locally
Set the timeout option of a GCP function and try to deploy it.
Related issues
Closes #16282