Cherry-pick #16139 to 7.x: Regenerate expected files after changes in date parsing #16175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elasticsearch has modified the behaviour on date parsing when the date doesn't include timezone data. Regenerate a couple of golden files that are affected by this change. (cherry picked from commit e61c4c4)
kaiyan-sheng
approved these changes
Feb 6, 2020
Contributor
kaiyan-sheng
left a comment
kaiyan-sheng
left a comment
There was a problem hiding this comment.
let's wait for CI to pass first 👍 thanks for fixing this.
Member
|
Looks like this is needed now, can we get this branch up to date with 7.x please? |
Member
Author
|
@graphaelli branch updated, but feel free to bring this change to #16699 and merge it all together. |
Contributor
|
ci failure in libbeat is caused by #16764 |
Member
|
merged as part of #16699, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #16139 to 7.x branch. Original message:
Elasticsearch has modified the behaviour on date parsing when the date
doesn't include timezone data. Regenerate a couple of golden files that
are affected by this change.
New values are actually correct, so this will fix some issues on logs without
timezone information.
I think the change in Elasticsearch is elastic/elasticsearch#51215
We will need to backport this for 7.7 as this change is going to be included
in Elasticsearch 7.7.