Add documentation about tool dependencies#16107
Merged
kvch merged 5 commits intoelastic:masterfrom Feb 6, 2020
Merged
Conversation
kvch
added
docs
[zube]: In Review
Team:Services
andrewkroh
approved these changes
Feb 5, 2020
dedemorton
reviewed
Feb 5, 2020
dedemorton
suggested changes
Feb 5, 2020
Contributor
dedemorton
left a comment
dedemorton
left a comment
There was a problem hiding this comment.
A few nits, otherwise looks good.
Co-Authored-By: Andrew Kroh <andrew.kroh@elastic.co>
Contributor
Author
|
Docs build is passing, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds information about tool dependencies to the contribution guide.
Why is it important?
Previously we did not specify what tools were required to run
go generatein the repo.Checklist
- [ ] My code follows the style guidelines of this project- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksRelated issues
#15998