Added migration script from 1.x to 5.0 configuration files #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't do yaml parsing, just line by line string operations. This means it is not able to transform any yaml syntax, but should work on the most common cases. On the plus side, it uses only python standard library modules and it keeps the comments as in the original file. Related to elastic#1488.
|
I really like the idea of having this kind of scripts. Alternatively it could be shipped as an additional Golang binary (beat-helper ;-) ) but as we know, YAML parsing etc. has its issues here. Python is probably available on most environments and it is cross platform compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't do yaml parsing, just line by line string operations. This means
it is not able to transform any yaml syntax, but should work on the most
common cases.
On the plus side, it uses only python standard library modules and it keeps
the comments as in the original file. Related to #1488.