Skip to content

[metricbeat]kubernetes: ksm service labels#15190

Merged
odacremolbap merged 2 commits intoelastic:masterfrom
odacremolbap:task/ksm-service-labels
Dec 18, 2019
Merged

[metricbeat]kubernetes: ksm service labels#15190
odacremolbap merged 2 commits intoelastic:masterfrom
odacremolbap:task/ksm-service-labels

Conversation

@odacremolbap
Copy link
Copy Markdown
Contributor

Merging #15066 included:

  • setting label fields at the kubernetes module level at the event
  • removing label prefixes for those that begin with label_

this PR brings those changes to the already merged state_service metricset.
The metricset is new, non released yet, there is no need for CHANGELOG nor does it breaks compatibility.

@odacremolbap odacremolbap requested a review from a team as a code owner December 18, 2019 15:41
@odacremolbap odacremolbap added containers Related to containers use case Metricbeat Metricbeat Team:Integrations Label for the Integrations team review labels Dec 18, 2019
@odacremolbap odacremolbap changed the title Task/ksm service labels [metricbeat]kubernetes: ksm service labels Dec 18, 2019
@@ -1,50 +1,47 @@
{
"@timestamp": "2019-11-27T18:13:26.661Z",
"@timestamp": "2019-12-18T14:47:52.427Z",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting this actually uses the current timestamp. In x-pack/aws, seems like there is a default timestamp: https://github.com/elastic/beats/blob/master/x-pack/metricbeat/module/aws/billing/_meta/data.json#L2

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I launch metricbeat with debug output and copy data.json from there.
Have been doing that for a while, probably there is some other way of obtaining that file.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm for most of the modules/metricsets, I see a TestData function that generates data.json like https://github.com/elastic/beats/blob/master/x-pack/metricbeat/module/aws/billing/billing_integration_test.go#L16

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thanks for sharing!

Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@odacremolbap odacremolbap merged commit d9b85b0 into elastic:master Dec 18, 2019
@odacremolbap odacremolbap deleted the task/ksm-service-labels branch December 18, 2019 21:18
@odacremolbap odacremolbap added the needs_backport PR is waiting to be backported to other branches. label Jan 3, 2020
odacremolbap pushed a commit to odacremolbap/beats that referenced this pull request Jan 3, 2020
* use labels transformation for state_service

(cherry picked from commit d9b85b0)
@odacremolbap odacremolbap added v7.6.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 3, 2020
odacremolbap pushed a commit that referenced this pull request Jan 3, 2020
* use labels transformation for state_service

(cherry picked from commit d9b85b0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

containers Related to containers use case Metricbeat Metricbeat review Team:Integrations Label for the Integrations team v7.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants