[Agent] Agent UUID step 1#15144
Merged
michalpristas merged 9 commits intoelastic:fleetfrom Dec 19, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/ingest (Project:fleet) |
houndci-bot
reviewed
Dec 17, 2019
houndci-bot
reviewed
Dec 17, 2019
houndci-bot
reviewed
Dec 17, 2019
houndci-bot
reviewed
Dec 17, 2019
ph
reviewed
Dec 17, 2019
| // NewCheckinCmd creates a new api command. | ||
| func NewCheckinCmd(agentID string, client clienter) *CheckinCmd { | ||
| const p = "/api/fleet/agents/%s/checkin" | ||
| func NewCheckinCmd(agentID func() string, client clienter) *CheckinCmd { |
Contributor
There was a problem hiding this comment.
@michalpristas What if we try to make it more future proof and we have an AgentInfo struct that expose the ID() method, this will effectively limit required changes if we have more internal data to pass around the code?
houndci-bot
reviewed
Dec 17, 2019
houndci-bot
reviewed
Dec 17, 2019
Contributor
|
We are close a few hounds comments :) |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* uuid for agent id * fixed hound dog * pass agent info * pass agent info * agent infor comments * notice update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step generates ID as UUID and allows components where agentID is injected to get latest UUID always (by injecting get method instead of value)