[metricbeat]kubernetes: add kube-state-metrics persistentvolumes#14859
Merged
odacremolbap merged 12 commits intoelastic:masterfrom Dec 19, 2019
Merged
[metricbeat]kubernetes: add kube-state-metrics persistentvolumes#14859odacremolbap merged 12 commits intoelastic:masterfrom
odacremolbap merged 12 commits intoelastic:masterfrom
Conversation
odacremolbap
added
in progress
houndci-bot
reviewed
Nov 29, 2019
odacremolbap
added
review
and removed
in progress
(probably) better blank line formatting
Contributor
Author
exekias
reviewed
Dec 16, 2019
| kube_persistentvolume_labels{persistentvolume="test-unlabeled-pv"} 1 | ||
| # HELP kube_persistentvolume_capacity_bytes Persistentvolume capacity in bytes. | ||
| # TYPE kube_persistentvolume_capacity_bytes gauge | ||
| kube_persistentvolume_capacity_bytes{persistentvolume="test-pv"} 5.36870912e+09 |
Contributor
There was a problem hiding this comment.
how come this one (test-pv) doesn't have an status phase?
Contributor
Author
There was a problem hiding this comment.
those test cases are taken from kube-state-metrics unit tests in order to test all tested cases upstream. Those are not real but created at ksm for each of the supported scenarios.
Using a (real) resource from one of our kubernetes clusters targeted a very small subset of cases.
exekias
approved these changes
Dec 16, 2019
Contributor
exekias
left a comment
exekias
left a comment
There was a problem hiding this comment.
left a question about tests but lgtm
Contributor
Author
|
Changes requested at #15066 (comment) have been also applied to this metricset. reviews are again welcomed |
exekias
approved these changes
Dec 19, 2019
Contributor
|
I see #15066 backported, but not this one. Is it? |
odacremolbap
pushed a commit
to odacremolbap/beats
that referenced
this pull request
Jan 3, 2020
…stic#14859) kube-state-metrics persistent volumes metrics for kubernetes (cherry picked from commit a586a35)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kubernetes volume metrics for kube-state-metrics.
refer to:
https://github.com/kubernetes/kube-state-metrics/blob/master/docs/persistentvolume-metrics.md
related to #14821