Fix cluster-wide Kafka client bug#14857
Merged
ChrsMark merged 2 commits intoelastic:masterfrom Nov 29, 2019
Merged
Conversation
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added
bug
review
[zube]: In Review
Team:Integrations
mtojek
approved these changes
Nov 29, 2019
Contributor
mtojek
left a comment
mtojek
left a comment
There was a problem hiding this comment.
It would be nice if it's possible to cover these changes with an integration test or sth. Anyway, approved!
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Member
Author
|
@mtojek thanks for reviewing! I checked about the test addition and I tuned a little bit the current one so as to |
Contributor
|
Cool! Thanks for the heads up. |
ChrsMark
added
the
needs_backport
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Nov 29, 2019
(cherry picked from commit 6c279eb)
ChrsMark
removed
the
needs_backport
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Nov 29, 2019
(cherry picked from commit 6c279eb)
ChrsMark
added a commit
that referenced
this pull request
Nov 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced on #14822.
The cluster-wide client was never re-opened after the first call to
Fetchmethod because all the other times theConnectmethod to broker was returning before the cluster-wide client initialisation, due tobeats/metricbeat/module/kafka/broker.go
Line 126 in 4f0b4f9
cc: @jsoriano @mtojek