Cherry-pick #14330 to 7.x: [Metricbeat] Add Kafka JMX metricsets#14656
Merged
ChrsMark merged 4 commits intoelastic:7.xfrom Nov 21, 2019
Merged
Cherry-pick #14330 to 7.x: [Metricbeat] Add Kafka JMX metricsets#14656ChrsMark merged 4 commits intoelastic:7.xfrom
ChrsMark merged 4 commits intoelastic:7.xfrom
Conversation
(cherry picked from commit 87c49ac)
Signed-off-by: chrismark <chrismarkou92@gmail.com>
jsoriano
reviewed
Nov 21, 2019
|
|
||
| # Credentials file for the service account with authorization to read from | ||
| # the subscription. | ||
| var.credentials_file: ${path.config}/gcp-service-account-xyz.json |
Member
There was a problem hiding this comment.
Not related? CI jobs seem to be failing because of this. Run mage fmt update and commit the changes.
Member
Author
There was a problem hiding this comment.
Yes the whole file was removed on #14553 accidentally. Will run the updates, thank you!
Signed-off-by: chrismark <chrismarkou92@gmail.com>
kaiyan-sheng
approved these changes
Nov 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #14330 to 7.x branch. Original message:
Implements
kafka.broker,kafka.consumer,kafka.producermetricset of #13366.Depends on:
Manual Testing
Broker metricset
In order to prepare the proper environment to test these metricsets, the quickest way is to reuse the Docker env of the module. This can be achieved by first of all running the integration tests of the module which will take care of bringing up the container with the proper configuration.
To run the tests:
go test -v -tags=integration github.com/elastic/beats/metricbeat/module/kafka/partitionVerify that tests are successful and you can go on to manual testing. After the tests have finished the container is still alive so we can use it for the manual testing too.
Check what are the exported ports from Docker with a
docker ps:5da9631cfa25 docker.elastic.co/observability-ci/beats-integration-kafka:2.1.1-1 "/run.sh" 23 minutes ago Up 23 minutes (healthy) 2181/tcp, 0.0.0.0:32771->8774/tcp, 0.0.0.0:32770->8775/tcp, 0.0.0.0:32769->8779/tcp, 0.0.0.0:32768->9092/tcp metricbeat_kafka_1In this example the mapping is:
0.0.0.0:32769->87790.0.0.0:32770->87750.0.0.0:32771->8774So we configure the metricsets' hosts accordingly.
Enable the Kafka module and use the following configuration in
modules.d/kafka.yml:Run Metricbeat and verify that metrics are being collected from all of the 3 metricsets we configured.
When done remove the testing container.