Cherry-pick #14498 to 7.x: Replace generate_imports python script with mage imports#14529
Merged
ChrsMark merged 4 commits intoelastic:7.xfrom Nov 19, 2019
Merged
Cherry-pick #14498 to 7.x: Replace generate_imports python script with mage imports#14529ChrsMark merged 4 commits intoelastic:7.xfrom
ChrsMark merged 4 commits intoelastic:7.xfrom
Conversation
(cherry picked from commit 6b46c29)
ChrsMark
added
backport
review
Team:Integrations
odacremolbap
approved these changes
Nov 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #14498 to 7.x branch. Original message:
This PR tries to refactor and unify the way we create
include/list.gofiles. This came after we moved light modules to OSS and while trying to create a light module under OSS. In that case this module will be included inlist.gofile despite the fact that it has no.gofiles. This was not a problem when light modules where underx-packbecause there thelist.gowas created bymageand the script was taking into consideration the existence of.gofiles in a module so as to decide if it should be included inlist.go.So far we had:
x-packway: https://github.com/elastic/beats/blob/master/x-pack/metricbeat/magefile.go#L128ossway: https://github.com/elastic/beats/blob/master/metricbeat/Makefile#L46This PR refactors the OSS part so as to make use of the
magerespective target likewisex-pack.cc: @jsoriano , @exekias