Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added beatname.sh in /usr/bin #1446

Merged
merged 2 commits into from
Apr 21, 2016
Merged

Added beatname.sh in /usr/bin #1446

merged 2 commits into from
Apr 21, 2016

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Apr 21, 2016

For Deb and Rpm installations. This makes it easy to run the Beat
in foreground, while still being executed with the write paths.
Part of #1371.

This sits on top op #1444, please have a look at that one first.

Tudor Golubenco added 2 commits April 21, 2016 12:03
For Deb and Rpm installations. This makes it easy to run the Beat
in foreground, while still being executed with the write paths.
Part of elastic#1371.
@tsg tsg added the review label Apr 21, 2016
@tsg tsg mentioned this pull request Apr 21, 2016
14 tasks
@ruflin
Copy link
Member

ruflin commented Apr 21, 2016

Nice, we should definitively also test this as part of beats-tester.

@ruflin ruflin merged commit 0a0294a into elastic:master Apr 21, 2016
-path.home /usr/share/{{.beat_name}} \
-path.config /etc/{{.beat_name}} \
-path.data /var/lib/{{.beat_name}} \
$@
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "$@" instead of $@? It affects how certain arguments get passed. StackOverflow

macbook13:tmp akroh$ cat foo.sh 
#!/bin/bash
./baz.sh $@
macbook13:tmp akroh$ cat bar.sh 
#!/bin/bash
./baz.sh "$@"
macbook13:tmp akroh$ cat baz.sh 
#!/bin/bash
echo Received: $1
echo Received: $2
echo Received: $3
echo Received: $4

macbook13:tmp akroh$ ./foo.sh -c="andrews config.yml"
Received: -c=andrews
Received: config.yml
Received:
Received:
macbook13:tmp akroh$ ./bar.sh -c="andrews config.yml"
Received: -c=andrews config.yml
Received:
Received:
Received:

@tsg tsg deleted the added_bin_sh branch August 25, 2016 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants