Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for the new directory layout #1441

Merged
merged 4 commits into from
Apr 22, 2016

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Apr 21, 2016

This adds the doc changes for #1371.

@dedemorton can you have a look if I gave enough details, now? For editing I think it's easier to merge it and edit it in future PRs, right?

===== data

The data path for a {beatname_uc} installation is the default base path for all
the files in which {beatname_uc} needs to store its files. If not set via a CLI
Copy link
Contributor

@dedemorton dedemorton Apr 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean to say "for all the folders in which...." (instead of "for all the files in which").

This description still seems a bit vague. It would help if you could say a bit more about how the files are used. Maybe providing an example or two would help.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you should probably say directories instead of folders here, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, I meant "store its data", not files. The reason I'm being vague is that this file is included for all beats, but not all beats put stuff in the data path. It's only Filebeat and Winlogbeat, which store their registry file. Topbeat and Packetbeat don't put anything in it for now, but that will probably change soon. That's why I'm not sure how to make it more concrete. Maybe we should just explain it like that (Filebeat and Winlogbeat store the registry file, Topbeat and Packetbeat currently don't use this setting).

@dedemorton
Copy link
Contributor

@tsg I've added a couple of comments where I think you need to say a bit more.

@tsg
Copy link
Contributor Author

tsg commented Apr 21, 2016

I fixed some things and added some examples at the beginning of the configuration page, hopefully that helps a little. It's difficult to be specific because some things depend from beat to beat, but these files are common.

@dedemorton
Copy link
Contributor

@tsg: LGTM. I'd also like to take a pass at editing this later, so please open a doc issue for that.

@andrewkroh
Copy link
Member

LGTM

@andrewkroh andrewkroh merged commit 00f0939 into elastic:master Apr 22, 2016
dedemorton added a commit to dedemorton/beats that referenced this pull request Apr 28, 2016
@tsg tsg deleted the docs_for_dir_layout branch August 25, 2016 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants