Switch over local build to use asciidoctor#13772
Merged
dedemorton merged 2 commits intoelastic:masterfrom Sep 25, 2019
Merged
Conversation
dedemorton
added
docs
needs_backport
nik9000
reviewed
Sep 24, 2019
script/build_docs.sh
Outdated
| fi | ||
|
|
||
| $docs_dir/build_docs $params --doc "$index" --out "$dest_dir" | ||
| $docs_dir/build_docs --asciidoctor $params --doc "$index" --out "$dest_dir" |
Member
There was a problem hiding this comment.
I think you want the --respect_edit_url_overrides here too.
Member
|
Lgtm
…On Tue, Sep 24, 2019, 21:41 DeDe Morton ***@***.***> wrote:
@dedemorton <https://github.com/dedemorton> requested your review on:
#13772 <#13772> Switch over local
build to use asciidoctor.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#13772?email_source=notifications&email_token=AABUXIQXFEP3NXHZ6NX7DQTQLK6WPA5CNFSM4IZULPFKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOT2GKSVI#event-2660018517>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABUXIRLXXMZGTQYU6WZAZLQLK6WPANCNFSM4IZULPFA>
.
|
Contributor
Author
|
@nik9000 How far back do you think I should backport this? I think devs will still want to use the |
Member
|
I'd probably go all the way back just for maximum paranoia's sake. So long as the merge is clean. Once it starts to get unclean I'd think pretty hard about stopping. |
Contributor
Author
|
@urso What do think? After spending countless hours backporting the asciidoctor fixes, I don't want to waste time backporting to branches we'll never touch again. |
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 27, 2019
* Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 27, 2019
* Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 27, 2019
* Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 27, 2019
* Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 27, 2019
* Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 27, 2019
* Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 27, 2019
* Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 27, 2019
* Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 27, 2019
* Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
dedemorton
added a commit
to dedemorton/beats
that referenced
this pull request
Sep 27, 2019
* Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
dedemorton
added a commit
that referenced
this pull request
Sep 27, 2019
dedemorton
added a commit
that referenced
this pull request
Sep 27, 2019
dedemorton
added a commit
that referenced
this pull request
Sep 27, 2019
dedemorton
added a commit
that referenced
this pull request
Sep 27, 2019
dedemorton
added a commit
that referenced
this pull request
Sep 27, 2019
dedemorton
added a commit
that referenced
this pull request
Sep 27, 2019
dedemorton
added a commit
that referenced
this pull request
Sep 27, 2019
dedemorton
added a commit
that referenced
this pull request
Sep 27, 2019
dedemorton
added a commit
that referenced
this pull request
Sep 27, 2019
dedemorton
removed
the
needs_backport
dedemorton
added a commit
that referenced
this pull request
Oct 7, 2019
dedemorton
added a commit
that referenced
this pull request
Oct 7, 2019
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Oct 8, 2019
Follows the change in elastic#13772 to switch over local build to use asciidoctor and adds respect_edit_url_overrides flag.
andrewkroh
added a commit
that referenced
this pull request
Nov 14, 2019
Follows the change in #13772 to switch over local build to use asciidoctor and adds respect_edit_url_overrides flag.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…3828) * Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…3837) * Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…3829) * Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…3836) * Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* [docs][APM] Update APM/Beats documentation (elastic#13596) * Fix region tags * Switch over local build to use asciidoctor (elastic#13772) * Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…3833) * Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…3830) * Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…3834) * Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…3835) * Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…3827) * Switch over local build to use asciidoctor * Add respect_edit_url_overrides flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge this change after the build is switched over to asciidoctor in elastic/docs#1178.