Skip to content

Cherry-pick #13651 to 7.4: Remove in_cluster from Kuberentes configuration examples#13688

Merged
ChrsMark merged 1 commit intoelastic:7.4from
ChrsMark:backport_13651_7.4
Sep 16, 2019
Merged

Cherry-pick #13651 to 7.4: Remove in_cluster from Kuberentes configuration examples#13688
ChrsMark merged 1 commit intoelastic:7.4from
ChrsMark:backport_13651_7.4

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented Sep 16, 2019

Cherry-pick of PR #13651 to 7.4 branch. Original message:

This configuration was removed by #13051.

This PR is clean up for any remaining references of this configuration filed.
Kudos to @jsoriano for bringing this up in #13473

cc: @odacremolbap, @exekias

@ChrsMark ChrsMark requested a review from a team as a code owner September 16, 2019 06:44
@ChrsMark ChrsMark changed the title Cherry-pick #13651 to 7.4: Remove in_cluster from doc examples Cherry-pick #13651 to 7.4: Remove in_cluster from Kuberentes configuration examples Sep 16, 2019
@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label Sep 16, 2019
@jsoriano
Copy link
Copy Markdown
Member

jenkins, test this again

Copy link
Copy Markdown
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think that failures in CI are not related but I'd like to see one of Jenkins or Travis jobs green before merging.

@ChrsMark
Copy link
Copy Markdown
Member Author

Jenkins failure seems unrelated. Merging since Travis build was successful.

@ChrsMark ChrsMark merged commit 946e1a6 into elastic:7.4 Sep 16, 2019
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants