Skip to content

[7.1] Un-skip flaky tests (#12388) #12416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ycombinator wants to merge 4 commits into from
Closed

[7.1] Un-skip flaky tests (#12388) #12416

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7807e8
Un-skip flaky tests (#12388)
ycombinator Jun 4, 2019
0886da2
Using the right interface
ycombinator Jun 4, 2019
7d69dad
Adding logging for temporary debugging
ycombinator Jun 7, 2019
369739d
Removing temporary logging
ycombinator Jun 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions metricbeat/module/elasticsearch/elasticsearch_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ var metricSets = []string{
}

func TestFetch(t *testing.T) {
t.Skip("flaky")
compose.EnsureUp(t, "elasticsearch")

host := net.JoinHostPort(getEnvHost(), getEnvPort())
Expand Down Expand Up @@ -100,7 +99,6 @@ func TestFetch(t *testing.T) {
}

func TestData(t *testing.T) {
t.Skip("flaky")
compose.EnsureUp(t, "elasticsearch")

host := net.JoinHostPort(getEnvHost(), getEnvPort())
Expand Down Expand Up @@ -262,7 +260,7 @@ func createCCRStats(host string) error {
return checkCCRStatsExists(host)
}

exists, err := waitForSuccess(checkCCRStats, 200, 5)
exists, err := waitForSuccess(checkCCRStats, 300, 5)
if err != nil {
return errors.Wrap(err, "error checking if CCR stats exist")
}
Expand Down