Backport #12284 to 7.2: Import ECS 1.0.1#12299
Closed
webmat wants to merge 1 commit intoelastic:7.2from
Closed
Conversation
Merged
ruflin
approved these changes
May 27, 2019
ruflin
requested changes
May 27, 2019
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
Just realised we didn't update the Golang code dependency. This means internally we still report ECS version 1.0 instead of 1.0.1.
Contributor
Author
|
@ruflin I'm confused. What does this have to do with this PR? :-) |
Contributor
Author
|
Ah you mean the Golang generated code. You're right. 🤦♂ |
Contributor
Author
|
I won't have time to pick that up. A Beats dev should do that part. |
Contributor
|
I think it's important that we ship both at the same time (single PR) as otherwise we have an inconsistency between definition and what we ship as part of each event. @cwurm Could you pick this up? We also must fix "master" as it slipped through there. |
Contributor
Author
|
@ruflin Agreed. |
Contributor
|
PR for fixing it in master: #12317 |
Contributor
Author
|
This didn't make it. Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12284 to 7.2. Original message:
This is a patch release of ECS, as it only contains minor fixes, mostly field formatting, and examples for a few fields. No new fields in this release.
The killer feature of ECS 1.0.1 is elastic/ecs#454. This change will make pivoting around numeric values such as port numbers & PIDs much more streamlined, as it will prevent Kibana from adding thousands separators.
I'm hoping we can backport this to 7.2, as I think it fits really well with the introduction of the SIEM app.